Allow tns debug with Hot Module Replacement (HMR)
#4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitarTachev
force-pushed
the
tachev/debug-without-restart
branch
3 times, most recently
from
23a4007 to
0aaeb7e
Compare
Fatme
reviewed
Nov 16, 2018
DimitarTachev
force-pushed
the
tachev/debug-without-restart
branch
from
0aaeb7e to
52b5499
Compare
Fatme
reviewed
Nov 16, 2018
DimitarTachev
force-pushed
the
tachev/debug-without-restart
branch
from
52b5499 to
453aba1
Compare
|
run ci |
Fatme
approved these changes
Nov 19, 2018
DimitarTachev
force-pushed
the
tachev/debug-without-restart
branch
2 times, most recently
from
65f8457 to
7ac64f7
Compare
…oid restarts at the same time
DimitarTachev
force-pushed
the
tachev/debug-without-restart
branch
from
38a45a4 to
4b6d169
Compare
…void infinite wait on ctrl+c
…ing the proxy on app restart
…reate a new one for the next proxy
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
tns debug android --hmrandtns debug ios --hmrare restarting the app on each file change regardless of the HMR flag and the debug sessions are disconnected.What is the new behavior?
tns debug android --hmrandtns debug ios --hmrare not restarting the app allowing the debug session to continue even on a javascript file change.Related to #2992